[libc-commits] [PATCH] D148797: [libc] Start to refactor riscv platform abstraction to support both 32 and 64 bits versions

[Mikhail Ramalho via Phabricator via libc-commits]

mikhail.ramalho added a comment.

In D148797#4299288 <https://reviews.llvm.org/D148797#4299288>, @sivachandra wrote:

> This change LGTM in general. But, I would like to have instructions on how to test this before I accept it. Couple of reasons:
>
> 1. We want to have an estimate for the public CI.

Sorry, I didn't understand the question. What do you mean by that?

> 2. Since this patch is unifying riscv64 and riscv32, I want to see how much of riscv32 actually works. Things like, if a riscv64 change does not work for riscv32, would we require that the contributor/patch author block on riscv32 changes?

So far most of the changes needed to port the code to rv32 are related to either UInt<128> not playing nice with the rest of the code or the need to use alternative syscalls (usually with the suffix 64). Once the current patches land, all the test cases with LIBC_FULL=OFF will pass.

Except for the assembly in longjmp/setjmp, the rest of the code should just work in rv32.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148797/new/

https://reviews.llvm.org/D148797