[libc-commits] [PATCH] D151935: [libc] Add strtoint32 and strtoint64 tests

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/test/src/stdlib/strtoint64_test.cpp:33
+                     int base) {
+  auto result = internal::strtointeger<uint64_t>(str, base);
+  if (result.has_error())
----------------
Nit: Not sure if we want to call the internal function or if we should do something like:

```
if constexpr (cpp::is_same_v<int64_t, long>)
  result = __llvm_libc::strtol(...);
else
  result = __llvm_libc::strtoll(...);
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151935/new/

https://reviews.llvm.org/D151935