[libc-commits] [PATCH] D151935: [libc] Add strtoint32 and strtoint64 tests

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Jun 1 14:05:22 PDT 2023


michaelrj created this revision.
michaelrj added a reviewer: sivachandra.
Herald added subscribers: libc-commits, tschuett.
Herald added projects: libc-project, All.
michaelrj requested review of this revision.

There were regressions in the testing framework due to none of the
functioning buildbots having a 32 bit long. This allowed the 32 bit
version of the strtointeger function to go untested. This patch adds
tests for strtoint32 and strtoint64, which are internal testing
functions that use constant integer sizes. It also fixes the tests to
properly handle these situations.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D151935

Files:
  libc/test/src/stdlib/CMakeLists.txt
  libc/test/src/stdlib/StrtolTest.h
  libc/test/src/stdlib/atoi_test.cpp
  libc/test/src/stdlib/atol_test.cpp
  libc/test/src/stdlib/strtod_test.cpp
  libc/test/src/stdlib/strtof_test.cpp
  libc/test/src/stdlib/strtoint32_test.cpp
  libc/test/src/stdlib/strtoint64_test.cpp
  libc/test/src/stdlib/strtol_test.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D151935.527610.patch
Type: text/x-patch
Size: 9841 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230601/731b2d77/attachment.bin>


More information about the libc-commits mailing list