[libc-commits] [PATCH] D154848: [libc] Remove test RPC opcodes from the exported header
    Johannes Doerfert via Phabricator via libc-commits 
    libc-commits at lists.llvm.org
       
    Mon Jul 10 10:43:32 PDT 2023
    
    
  
jdoerfert added inline comments.
================
Comment at: libc/include/llvm-libc-types/test_rpc_opcodes_t.h:12-15
+typedef enum : unsigned short {
+  RPC_TEST_INCREMENT = 1 << 15 | 1,
+  RPC_TEST_INTERFACE = 1 << 15 | 2,
+  RPC_TEST_STREAM = 1 << 15 | 3,
----------------
Make an extension constant `1<<15` and then it becomes much clearer what's going on. Still, add documentation.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154848/new/
https://reviews.llvm.org/D154848
    
    
More information about the libc-commits
mailing list