[libc-commits] [PATCH] D154848: [libc] Remove test RPC opcodes from the exported header

[Joseph Huber via Phabricator via libc-commits]

jhuber6 created this revision.
jhuber6 added reviewers: jdoerfert, JonChesterfield, sivachandra, lntue, michaelrj.
Herald added subscribers: libc-commits, mattd, asavonic, kerbowa, jvesely.
Herald added projects: libc-project, All.
jhuber6 requested review of this revision.

This patch does the noisy work of removing the test opcodes from the
exported interface to an interface that is only visible in `libc`. The
benefit of this is that we both test the exported RPC registration more
directly, and we do not need to give this interface to users.

I have decided to export any opcode that is not a "core" libc feature as
having its MSB set in the opcode. We can think of these as non-libc
"extensions".


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D154848

Files:
  libc/include/llvm-libc-types/rpc_opcodes_t.h
  libc/include/llvm-libc-types/test_rpc_opcodes_t.h
  libc/test/integration/startup/gpu/rpc_interface_test.cpp
  libc/test/integration/startup/gpu/rpc_stream_test.cpp
  libc/test/integration/startup/gpu/rpc_test.cpp
  libc/utils/gpu/loader/Loader.h
  libc/utils/gpu/loader/amdgpu/Loader.cpp
  libc/utils/gpu/loader/nvptx/Loader.cpp
  libc/utils/gpu/server/rpc_server.cpp
  libc/utils/gpu/server/rpc_server.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154848.538642.patch
Type: text/x-patch
Size: 13229 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230710/04177770/attachment-0001.bin>