[libc-commits] [PATCH] D144214: [libc] Support add_object_library for the GPU build

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added a comment.
This revision is now accepted and ready to land.

LGTM, but I have left a naming suggestion.



================
Comment at: libc/startup/gpu/nvptx/CMakeLists.txt:13
     --offload-arch=${LIBC_GPU_TARGET_ARCHITECTURE}
+  NO_GPU_BUILD # Compile this file directly without special GPU handling.
 )
----------------
The name `NO_GPU_BUILD` seems odd when you do have `LIBC_GPU_TARGET_ARCHITECTURE`. May be name it `NO_GPU_BUNDLE`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144214/new/

https://reviews.llvm.org/D144214