[libc-commits] [PATCH] D144214: [libc] Support add_object_library for the GPU build

[Tue Ly via Phabricator via libc-commits]

lntue added a comment.

Overall it looks good to me, but let's wait for @sivachandra to comment on the patch.

Also, I just noticed that `build_gpu_objects` is called after `FLAGS` expansion (via the chain `add_entrypoint_object -> expand_flags_for_entrypoint_object -> create_entrypoint_object -> build_gpu_objects`),
so for an entry point object with some FLAGS properties (that are currently used to create multiple targets for different CPU configurations, especially in math functions), redundant GPU targets will be generated.
This is probably not a problem with the current set of entry points enabled for GPU yet.

Anyway since we are going to push CMake version to 3.20 matching LLVM updated requirements, it's probably a good time for me to revise the `FLAGS` implementations make sure it works well with other use cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144214/new/

https://reviews.llvm.org/D144214