[libc-commits] [PATCH] D143006: [libc] add printf auto float conversion

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/test/src/stdio/sprintf_test.cpp:2121
+
+  // TODO: Fix long doubles (needs bigger table or alternate algorithm.)
+  // Currently the table values are generated, which is very slow.
----------------
michaelrj wrote:
> sivachandra wrote:
> > Does this TODO belong here or somewhere in the implementation?
> Probably yes, but it's also here to explain why the long double tests are commented out.
In the test, you should add a comment like, `TODO: Uncomment the below tests after long double support is added.` And in the implementaiton, add a comment like, `TODO: Extend the algorithm for long doubles with a bigger table, or use an alternate algorithm." Otherwise, it feels like the TODO is for the tests and not for the implementation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143006/new/

https://reviews.llvm.org/D143006