[libc-commits] [PATCH] D143006: [libc] add printf auto float conversion

[Michael Jones via Phabricator via libc-commits]

michaelrj added inline comments.


================
Comment at: libc/test/src/stdio/sprintf_test.cpp:2121
+
+  // TODO: Fix long doubles (needs bigger table or alternate algorithm.)
+  // Currently the table values are generated, which is very slow.
----------------
sivachandra wrote:
> Does this TODO belong here or somewhere in the implementation?
Probably yes, but it's also here to explain why the long double tests are commented out.


================
Comment at: libc/test/src/stdio/sprintf_test.cpp:2696
+  // written = __llvm_libc::sprintf(buff, "abc123%n", nullptr);
+  // EXPECT_LT(written, 0);
 }
----------------
sivachandra wrote:
> Why is this commented out?
I commented it out because I was testing the code with the system's sprintf, and this test was causing a segfault. I'll likely remove this test and the special case I put in in a separate patch because it's not necessary or in the standard.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143006/new/

https://reviews.llvm.org/D143006