[libc-commits] [libc] [libc] remove spurious LIBC_INLINE (PR #74505)

[via libc-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libc

Author: Nick Desaulniers (nickdesaulniers)

<details>
<summary>Changes</summary>

This function is marked noinline; the inline keyword (or whatever LIBC_INLINE
resolves to) will have no effect.


---
Full diff: https://github.com/llvm/llvm-project/pull/74505.diff


1 Files Affected:

- (modified) libc/src/__support/threads/linux/thread.cpp (+1-1) 


``````````diff
diff --git a/libc/src/__support/threads/linux/thread.cpp b/libc/src/__support/threads/linux/thread.cpp
index 5c84266ee5d0e..fcf87cc587a50 100644
--- a/libc/src/__support/threads/linux/thread.cpp
+++ b/libc/src/__support/threads/linux/thread.cpp
@@ -176,7 +176,7 @@ cleanup_thread_resources(ThreadAttributes *attrib) {
 #endif
 }
 
-[[gnu::noinline]] LIBC_INLINE void start_thread() {
+[[gnu::noinline]] void start_thread() {
   auto *start_args = reinterpret_cast<StartArgs *>(get_start_args_addr());
   auto *attrib = start_args->thread_attrib;
   self.attrib = attrib;

``````````

</details>


https://github.com/llvm/llvm-project/pull/74505