[libc-commits] [libc] [libc] remove spurious LIBC_INLINE (PR #74505)

Nick Desaulniers via libc-commits libc-commits at lists.llvm.org
Tue Dec 5 10:06:12 PST 2023


https://github.com/nickdesaulniers created https://github.com/llvm/llvm-project/pull/74505

This function is marked noinline; the inline keyword (or whatever LIBC_INLINE
resolves to) will have no effect.


>From 2dabb52a029d7f27d591bcc82458078db24cca01 Mon Sep 17 00:00:00 2001
From: Nick Desaulniers <ndesaulniers at google.com>
Date: Tue, 5 Dec 2023 10:04:57 -0800
Subject: [PATCH] [libc] remove spurious LIBC_INLINE

This function is marked noinline; the inline keyword (or whatever LIBC_INLINE
resolves to) will have no effect.
---
 libc/src/__support/threads/linux/thread.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libc/src/__support/threads/linux/thread.cpp b/libc/src/__support/threads/linux/thread.cpp
index 5c84266ee5d0e..fcf87cc587a50 100644
--- a/libc/src/__support/threads/linux/thread.cpp
+++ b/libc/src/__support/threads/linux/thread.cpp
@@ -176,7 +176,7 @@ cleanup_thread_resources(ThreadAttributes *attrib) {
 #endif
 }
 
-[[gnu::noinline]] LIBC_INLINE void start_thread() {
+[[gnu::noinline]] void start_thread() {
   auto *start_args = reinterpret_cast<StartArgs *>(get_start_args_addr());
   auto *attrib = start_args->thread_attrib;
   self.attrib = attrib;



More information about the libc-commits mailing list