[libc-commits] [PATCH] D158774: [libc] Add GPU support for `printf` and `fprintf`

[Matt Arsenault via Phabricator via libc-commits]

arsenm added inline comments.


================
Comment at: libc/src/stdio/gpu/parser.h:59
+  switch (c) {
+  case (' '):
+  case ('t'):
----------------
Why all the ()s


================
Comment at: libc/utils/gpu/server/rpc_server.cpp:111
+    results[lane] = fwrite(buffer, 1, writer.get_chars_written(), files[lane]);
+    delete[] reinterpret_cast<uint8_t *>(buffer);
+  }
----------------
use unique_ptr<>?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158774/new/

https://reviews.llvm.org/D158774