[libc-commits] [PATCH] D158774: [libc] Add GPU support for `printf` and `fprintf`
Jan-Patrick Lehr via Phabricator via libc-commits
libc-commits at lists.llvm.org
Thu Aug 24 14:06:25 PDT 2023
jplehr added inline comments.
================
Comment at: libc/src/__support/arg_list.h:73
+ LIBC_INLINE ArrayArgList(va_list) {}
+ LIBC_INLINE ArrayArgList(ArrayArgList &other) {
+ idx = other.idx;
----------------
Should the argument be `const &` here and below?
================
Comment at: libc/utils/gpu/server/rpc_server.cpp:94
+
+ char *buffer = new char[buffer_size];
+ WriteBuffer wb(buffer, buffer_size);
----------------
Allocating char here and deleting `uint8_t` later on.
Is there a particular reason for the type difference?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158774/new/
https://reviews.llvm.org/D158774
More information about the libc-commits
mailing list