[libc-commits] [PATCH] D148797: [libc] Start to refactor riscv platform abstraction to support both 32 and 64 bits versions

[Mikhail Ramalho via Phabricator via libc-commits]

mikhail.ramalho added a comment.

In D148797#4596926 <https://reviews.llvm.org/D148797#4596926>, @michaelrj wrote:

> If you have a plan for your buildbot then I think we can add RISC-V 32 as a supported platform. I've added some comments on this patch, but since I will be OOO soon I won't be able to give final approval.

We should probably have it running by next week, I already submitted the required changes to llvm-zorg. It will be on staging for now, until we are sure that it's working properly.



================
Comment at: libc/src/__support/OSUtil/linux/syscall.h:23
+#elif defined(LIBC_TARGET_ARCH_IS_ANY_RISCV)
+#include "riscv/syscall.h"
 #endif
----------------
michaelrj wrote:
> are syscalls exactly the same for RISC-V 32 and 64? If not, is it worthwhile to keep these separate?
Do you mean the syscall numbers? The ones defined in `syscall_numbers.h.inc`? 

If so, they are all guarded by the corresponding `#ifdef __NR_*`... This `riscv/syscall.h` file only defines the macros to call the syscalls. 


================
Comment at: libc/test/src/math/exhaustive/CMakeLists.txt:24
     -lpthread
+    -latomic
 )
----------------
michaelrj wrote:
> why do these all need atomic?
They were failing with a missing atomic dependency when using stdout, I'll re-run the tests without it now that we have a new interface for it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148797/new/

https://reviews.llvm.org/D148797