[libc-commits] [PATCH] D148797: [libc] Start to refactor riscv platform abstraction to support both 32 and 64 bits versions

[Michael Jones via Phabricator via libc-commits]

michaelrj added a comment.
Herald added a subscriber: sunshaoce.

If you have a plan for your buildbot then I think we can add RISC-V 32 as a supported platform. I've added some comments on this patch, but since I will be OOO soon I won't be able to give final approval.



================
Comment at: libc/src/__support/OSUtil/linux/syscall.h:23
+#elif defined(LIBC_TARGET_ARCH_IS_ANY_RISCV)
+#include "riscv/syscall.h"
 #endif
----------------
are syscalls exactly the same for RISC-V 32 and 64? If not, is it worthwhile to keep these separate?


================
Comment at: libc/test/src/math/exhaustive/CMakeLists.txt:24
     -lpthread
+    -latomic
 )
----------------
why do these all need atomic?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148797/new/

https://reviews.llvm.org/D148797