[libc-commits] [PATCH] D148797: [libc] Start to refactor riscv platform abstraction to support both 32 and 64 bits versions

Tue Apr 25 09:26:18 PDT 2023

mikhail.ramalho added a comment.

> Are you able to validate your guess with testing?

For the current code, yes. I'm currently changing the floating-point code to properly handle UInt<128> and so far it's working properly. I'm not sure about the code when libc_full=ON is enabled but I'm only foreseeing the setjmp/longjmp issue I've mentioned.

I can send a bigger patch when both riscv32/64 are enabled if you fell that's a better approach.

> Can you start a discourse thread with detailed instructions on how to setup the riscv32 emulator? Or, feel free to send a riscv focused doc patch - we will figure out where and how exactly to land it during the review.

Sure, I was planning to write a blog post about it too soon.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148797/new/

https://reviews.llvm.org/D148797