[libc-commits] [PATCH] D148797: [libc] Start to refactor riscv platform abstraction to support both 32 and 64 bits versions

Tue Apr 25 09:17:18 PDT 2023

sivachandra added a comment.

In D148797#4293642 <https://reviews.llvm.org/D148797#4293642>, @mikhail.ramalho wrote:

> My guess is that the code will just work... I believe the only change between the two targets is setjmp/longjmp, where the 64 bits version uses fld, ld, sd, fsd, and the 32 bits will need flw, lw, sw, fsw.

Are you able to validate your guess with testing?

> In D148797#4292916 <https://reviews.llvm.org/D148797#4292916>, @sivachandra wrote:
>
>> This is fine. But, can you share the status of what works and what does not on riscv32 and also your riscv32 environment?
>
> Sure, in the commit message, you mean?

Yes, in the commit message at the least.

> For testing, I'm using:
>
>   root at qemuriscv32:~# uname -a
>   Linux qemuriscv32 6.1.20-yocto-standard #1 SMP PREEMPT Sat Mar 18 02:48:04 UTC 2023 riscv32 GNU/Linux

Can you start a discourse thread with detailed instructions on how to setup the riscv32 emulator? Or, feel free to send a riscv focused doc patch - we will figure out where and how exactly to land it during the review.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148797/new/

https://reviews.llvm.org/D148797