[libc-commits] [PATCH] D148371: [libc] Add support to compile some syscalls on 32 bit platform

[Siva Chandra via Phabricator via libc-commits]

sivachandra added a comment.

- Mostly LGTM but one suggestion: at all places where you added alternate paths to `*64` syscalls, can you add commentary on when they will kick in and why they are to used?
- I will make another detailed pass over the `wait*` wrappers.



================
Comment at: libc/src/__support/threads/linux/mutex.h:83
                                   FutexWordType(LockState::Waiting), 0, 0, 0);
+#elif defined(SYS_futex_time64)
+        __llvm_libc::syscall_impl(SYS_futex_time64, &futex_word.val,
----------------
Can we add a constant, say `FUTEX_SYSCALL_ID` in https://github.com/llvm/llvm-project/blob/main/libc/src/__support/threads/linux/futex_word.h and avoid these widespread `ifdef`s?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148371/new/

https://reviews.llvm.org/D148371