[libc-commits] [PATCH] D148371: [libc] Add support to compile some syscalls on 32 bit platform

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Apr 24 10:25:52 PDT 2023


michaelrj added a comment.

we should probably figure out what the appropriate `waitpid` `errno` values are before landing this. It's possible that the syscall returns them as negative numbers, but I haven't tested it yet.



================
Comment at: libc/src/sched/linux/sched_rr_get_interval.cpp:31
+  }
+  return ret;
+#else
----------------
should this `return ret` be here or should it instead fall down to the handling below?

also should `ret` be a long to match the other syscall above?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148371/new/

https://reviews.llvm.org/D148371



More information about the libc-commits mailing list