[libc-commits] [PATCH] D134567: [libc] Re-enable functions from signal.h and re-enable abort.

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Sep 23 14:51:47 PDT 2022


sivachandra created this revision.
sivachandra added reviewers: abrachet, lntue, michaelrj.
Herald added subscribers: libc-commits, ecnelises, tschuett, pengfei, kristof.beyls.
Herald added projects: libc-project, All.
sivachandra requested review of this revision.

They were disabled because we were including linux/signal.h from our
signal.h. Linux's signal.h is not designed to be included from user
programs as it causes a lot of non-standard name pollution. Also, it is
not self-contained. This change defines types and macros relevant for
signal related syscalls within libc's headers and removes inclusion of
Linux headers.

This patch enables the funtions only for x86_64. They will be enabled
for aarch64 also in a follow up patch after testing.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D134567

Files:
  libc/config/linux/api.td
  libc/config/linux/x86_64/entrypoints.txt
  libc/include/CMakeLists.txt
  libc/include/llvm-libc-macros/CMakeLists.txt
  libc/include/llvm-libc-macros/linux/CMakeLists.txt
  libc/include/llvm-libc-macros/linux/signal-macros.h
  libc/include/llvm-libc-macros/signal-macros.h
  libc/include/llvm-libc-types/CMakeLists.txt
  libc/include/llvm-libc-types/siginfo_t.h
  libc/include/llvm-libc-types/sigset_t.h
  libc/include/llvm-libc-types/struct_sigaction.h
  libc/include/llvm-libc-types/union_sigval.h
  libc/include/signal.h.def
  libc/spec/posix.td
  libc/src/CMakeLists.txt
  libc/src/signal/linux/CMakeLists.txt
  libc/src/signal/linux/raise.cpp
  libc/src/signal/linux/sigaction.cpp
  libc/src/signal/linux/sigaddset.cpp
  libc/src/signal/linux/sigdelset.cpp
  libc/src/signal/linux/sigemptyset.cpp
  libc/src/signal/linux/sigfillset.cpp
  libc/src/signal/linux/signal.cpp
  libc/src/signal/linux/signal.h
  libc/src/signal/linux/signal_utils.h
  libc/src/signal/linux/sigprocmask.cpp
  libc/src/signal/sigaction.h
  libc/src/signal/sigaddset.h
  libc/src/stdlib/CMakeLists.txt
  libc/src/stdlib/linux/CMakeLists.txt
  libc/test/src/CMakeLists.txt
  libc/test/src/signal/sigaction_test.cpp
  libc/test/src/stdlib/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D134567.462592.patch
Type: text/x-patch
Size: 33682 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20220923/f3e8ca56/attachment-0001.bin>


More information about the libc-commits mailing list