[libc-commits] [libc] 736e215 - [libc][obvious] disable mprotect test under sanitizers

Michael Jones via libc-commits libc-commits at lists.llvm.org
Fri Sep 23 10:05:17 PDT 2022


Author: Michael Jones
Date: 2022-09-23T10:05:09-07:00
New Revision: 736e215ca783e07d6f352ef0c963fbfdf543e6a0

URL: https://github.com/llvm/llvm-project/commit/736e215ca783e07d6f352ef0c963fbfdf543e6a0
DIFF: https://github.com/llvm/llvm-project/commit/736e215ca783e07d6f352ef0c963fbfdf543e6a0.diff

LOG: [libc][obvious] disable mprotect test under sanitizers

fixes a build failure in my previous patch

Reviewed By: sivachandra

Differential Revision: https://reviews.llvm.org/D134552

Added: 
    

Modified: 
    libc/test/src/sys/mman/linux/CMakeLists.txt
    libc/test/src/sys/mman/linux/mprotect_test.cpp

Removed: 
    


################################################################################
diff  --git a/libc/test/src/sys/mman/linux/CMakeLists.txt b/libc/test/src/sys/mman/linux/CMakeLists.txt
index e903bd42c77e..cbc1accd2dfd 100644
--- a/libc/test/src/sys/mman/linux/CMakeLists.txt
+++ b/libc/test/src/sys/mman/linux/CMakeLists.txt
@@ -15,22 +15,24 @@ add_libc_unittest(
     libc.test.errno_setter_matcher
 )
 
-add_libc_unittest(
-  mprotect_test
-  SUITE
-    libc_sys_mman_unittests
-  SRCS
-    mprotect_test.cpp
-  DEPENDS
-    libc.include.errno
-    libc.include.sys_mman
-    libc.include.signal
-    libc.src.errno.errno
-    libc.src.sys.mman.mmap
-    libc.src.sys.mman.munmap
-    libc.src.sys.mman.mprotect
-    libc.test.errno_setter_matcher
-)
+if (NOT LLVM_USE_SANITIZER)
+  add_libc_unittest(
+    mprotect_test
+    SUITE
+      libc_sys_mman_unittests
+    SRCS
+      mprotect_test.cpp
+    DEPENDS
+      libc.include.errno
+      libc.include.sys_mman
+      libc.include.signal
+      libc.src.errno.errno
+      libc.src.sys.mman.mmap
+      libc.src.sys.mman.munmap
+      libc.src.sys.mman.mprotect
+      libc.test.errno_setter_matcher
+  )
+endif()
 
 add_libc_unittest(
   madvise_test

diff  --git a/libc/test/src/sys/mman/linux/mprotect_test.cpp b/libc/test/src/sys/mman/linux/mprotect_test.cpp
index 57f05bc1509a..06e0b51cb9a2 100644
--- a/libc/test/src/sys/mman/linux/mprotect_test.cpp
+++ b/libc/test/src/sys/mman/linux/mprotect_test.cpp
@@ -6,7 +6,6 @@
 //
 //===----------------------------------------------------------------------===//
 
-#include "include/signal.h"
 #include "src/sys/mman/mmap.h"
 #include "src/sys/mman/mprotect.h"
 #include "src/sys/mman/munmap.h"
@@ -14,6 +13,7 @@
 #include "utils/UnitTest/Test.h"
 
 #include <errno.h>
+#include <signal.h>
 #include <sys/mman.h>
 
 using __llvm_libc::testing::ErrnoSetterMatcher::Fails;


        


More information about the libc-commits mailing list