[libc-commits] [PATCH] D133960: [libc][cmake] separate installing headers
Siva Chandra via Phabricator via libc-commits
libc-commits at lists.llvm.org
Fri Sep 16 14:15:33 PDT 2022
sivachandra added inline comments.
Comment at: libc/CMakeLists.txt:153
+ COMPONENT libc-headers
> sivachandra wrote:
> > Since a real target is being added now, the whole block from line 144 to 165 should be moved to right before line 195.
> I don't think we should move it since `LIBC_TARGET` and `LIBC_COMPONENT` are used in some of the folders below. Specifically `LIBC_TARGET` is used in `lib` and `test` and `LIBC_COMPONENT` is used in `lib` and `loader`.
Ah, ok! Move just the new install target addition then?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libc-commits