[libc-commits] [PATCH] D133960: [libc][cmake] separate installing headers

[Michael Jones via Phabricator via libc-commits]

michaelrj added inline comments.


================
Comment at: libc/CMakeLists.txt:153
+    COMPONENT libc-headers
+  )
   set(LIBC_TARGET libc)
----------------
sivachandra wrote:
> Since a real target is being added now, the whole block from line 144 to 165 should be moved to right before line 195.
I don't think we should move it since `LIBC_TARGET` and `LIBC_COMPONENT` are used in some of the folders below. Specifically `LIBC_TARGET` is used in `lib` and `test` and `LIBC_COMPONENT` is used in `lib` and `loader`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133960/new/

https://reviews.llvm.org/D133960