[libc-commits] [PATCH] D136595: [libc] Switch to new implementation of mem* functions

[Guillaume Chatelet via Phabricator via libc-commits]

gchatelet marked 3 inline comments as done.
gchatelet added inline comments.


================
Comment at: libc/src/string/memory_utils/memcmp_implementations.h:97
+  }
+  if (generic::Bcmp<16>::block(p1, p2)) // [16, 16]
+    return generic::Memcmp<16>::block(p1, p2);
----------------
courbet wrote:
> This is unfortunate :(
> 
> This should be caught by unit tests, can you add one ?
Yep this was done in D136865


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136595/new/

https://reviews.llvm.org/D136595