[libc-commits] [PATCH] D136595: [libc] Switch to new implementation of mem* functions

Clement Courbet via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Oct 28 00:56:56 PDT 2022


courbet added inline comments.


================
Comment at: libc/src/string/memory_utils/memcmp_implementations.h:97
+  }
+  if (generic::Bcmp<16>::block(p1, p2)) // [16, 16]
+    return generic::Memcmp<16>::block(p1, p2);
----------------
This is unfortunate :(

This should be caught by unit tests, can you add one ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136595/new/

https://reviews.llvm.org/D136595



More information about the libc-commits mailing list