[libc-commits] [PATCH] D138608: [libc] Add initial support for a libc implementation for the GPU

Mon Nov 28 11:33:42 PST 2022

jhuber6 added a comment.

In D138608#3954164 <https://reviews.llvm.org/D138608#3954164>, @sivachandra wrote:

> I am accepting this patch. We should follow up with the following actions:

Thanks for being open to these additions to LLVM's libc.

> 1. Add clear documentation about what and how of GPU build. Like, how to build, test etc.

I'll try to add some basic documentation and include a list of supported functions soon.

> 2. Get a CI builder building and testing the GPU build. If this is being done on a non-libc builder, we should call it out somewhere in the libc documentation so that libc developers can find all the relevant information.
> 3. About tests, we should really be putting effort to use the same test code on all platforms. Different tests/systems for different platforms is added developer burden wrt writing them multiple times and then maintaining those multiple flavors.

Keeping the code common would be ideal. One problem is that the GPU currently doesn't support aliases, but there's less ambiguity on the GPU side when it comes to the libc functions so we may not need them to test. We may also want to avoid relying on other runtimes like OpenMP which may introduce their own bugs so it may be worthwhile to include our own launcher inside the test infrastructure. I'll look into it further as we definitely need tests.

> There should be some sort of urgency in addressing the above items. Need not happen now/today/tomorrow, but I think a reasonable time frame is that all of the above should be addressed within a month of landing this patch.

That should be doable.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138608/new/

https://reviews.llvm.org/D138608