[libc-commits] [PATCH] D138608: [libc] Add initial support for a libc implementation for the GPU

Mon Nov 28 10:30:04 PST 2022

sivachandra accepted this revision.
sivachandra added a comment.
This revision is now accepted and ready to land.

In D138608#3953107 <https://reviews.llvm.org/D138608#3953107>, @jhuber6 wrote:

> In D138608#3952535 <https://reviews.llvm.org/D138608#3952535>, @sivachandra wrote:
>
>> 2. What is the CI story for the GPU build? Everything, from who will own and maintain the CI builders, to the action that is to be taken if a patch breaks the GPU CI builders. Again, you don't have to stand up a GPU builders right away. You can choose to include the plan in the above documentation and work separately in setting up the buidlers.
>
> AMD has an active buildbot <https://lab.llvm.org/buildbot/#/builders/193> for testing the OpenMP runtime we could use for this. I haven't yet decided the best way to stand up tests for the GPU however. We can either use OpenMP offloading and modify the source code to run the region under test on the device or simply write GPU exclusive tests, maybe in another project. The problem with the former is it's not guaranteed to work as many existing test codes most likely contain code that can't be run on the GPU so we may still need some separation.

I am accepting this patch. We should follow up with the following actions:

1. Add clear documentation about what and how of GPU build. Like, how to build, test etc.
2. Get a CI builder building and testing the GPU build. If this is being done on a non-libc builder, we should call it out somewhere in the libc documentation so that libc developers can find all the relevant information.
3. About tests, we should really be putting effort to use the same test code on all platforms. Different tests/systems for different platforms is added developer burden wrt writing them multiple times and then maintaining those multiple flavors.

There should be some sort of urgency in addressing the above items. Need not happen now/today/tomorrow, but I think a reasonable time frame is that all of the above should be addressed within a month of landing this patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138608/new/

https://reviews.llvm.org/D138608