[libc-commits] [PATCH] D138608: [libc] Add initial support for a libc implementation for the GPU

[Joseph Huber via Phabricator via libc-commits]

jhuber6 added a comment.

In D138608#3952535 <https://reviews.llvm.org/D138608#3952535>, @sivachandra wrote:

> Thanks for the patch. The mechanical aspects of it LGTM but I have a few administrative questions and points to make:
>
> 1. You should add a doc in the `docs` directory describing what exactly is a GPU build, its status, how to build and and how to test. You don't have to cram all of this in this patch, but I would like to hear that you do intend to follow up with appropriate documentation.

Yes, I can add some documentation for how to run this build and how to use it.

> 2. What is the CI story for the GPU build? Everything, from who will own and maintain the CI builders, to the action that is to be taken if a patch breaks the GPU CI builders. Again, you don't have to stand up a GPU builders right away. You can choose to include the plan in the above documentation and work separately in setting up the buidlers.

AMD has an active buildbot <https://lab.llvm.org/buildbot/#/builders/193> for testing the OpenMP runtime we could use for this. I haven't yet decided the best way to stand up tests for the GPU however. We can either use OpenMP offloading and modify the source code to run the region under test on the device or simply write GPU exclusive tests, maybe in another project. The problem with the former is it's not guaranteed to work as many existing test codes most likely contain code that can't be run on the GPU so we may still need some separation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138608/new/

https://reviews.llvm.org/D138608