[libc-commits] [PATCH] D138608: [libc] Add initial support for a libc implementation for the GPU

[Siva Chandra via Phabricator via libc-commits]

sivachandra added a comment.

Thanks for the patch. The mechanical aspects of it LGTM but I have a few administrative questions and points to make:

1. You should add a doc in the `docs` directory describing what exactly is a GPU build, its status, how to build and and how to test. You don't have to cram all of this in this patch, but I would like to hear that you do intend to follow up with appropriate documentation.
2. What is the CI story for the GPU build? Everything, from who will own and maintain the CI builders, to the action that is to be taken if a patch breaks the GPU CI builders. Again, you don't have to stand up a GPU builders right away. You can choose to include the plan in the above documentation and work separately in setting up the buidlers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138608/new/

https://reviews.llvm.org/D138608