[libc-commits] [PATCH] D138111: [libc][benchmark] Fix wrong BatchSize leading to data not fitting in L1.

[Guillaume Chatelet via Phabricator via libc-commits]

gchatelet added inline comments.


================
Comment at: libc/benchmarks/LibcMemoryBenchmark.cpp:92
+  if (ParameterBytes + BufferBytes + L1LeftAsideBytes > getL1DataCacheSize())
+    report_fatal_error("Invalid state");
 }
----------------
courbet wrote:
> The error message is not very useful. Maybe something along the lines of:
> 
> `We're splitting a buffer of the size of the L1 cache between a data buffer and a benchmark parameters buffer, so by construction the total shoul dnot exceed the size of the L1 cache`
Much better, thx!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138111/new/

https://reviews.llvm.org/D138111