[libc-commits] [PATCH] D138111: [libc][benchmark] Fix wrong BatchSize leading to data not fitting in L1.

[Guillaume Chatelet via Phabricator via libc-commits]

This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2a6d4c5d8a4c: [libc][benchmark] Fix wrong BatchSize leading to data not fitting in L1. (authored by gchatelet).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138111/new/

https://reviews.llvm.org/D138111

Files:
  libc/benchmarks/LibcMemoryBenchmark.cpp


Index: libc/benchmarks/LibcMemoryBenchmark.cpp
===================================================================
--- libc/benchmarks/LibcMemoryBenchmark.cpp
+++ libc/benchmarks/LibcMemoryBenchmark.cpp
@@ -72,18 +72,27 @@
   report_fatal_error("Unable to read L1 Cache Data Size");
 }
 
+static constexpr int64_t KiB = 1024;
+static constexpr int64_t ParameterStorageBytes = 4 * KiB;
+static constexpr int64_t L1LeftAsideBytes = 1 * KiB;
+
 static size_t getAvailableBufferSize() {
-  static constexpr int64_t KiB = 1024;
-  static constexpr int64_t ParameterStorageBytes = 4 * KiB;
-  static constexpr int64_t L1LeftAsideBytes = 1 * KiB;
   return getL1DataCacheSize() - L1LeftAsideBytes - ParameterStorageBytes;
 }
 
 ParameterBatch::ParameterBatch(size_t BufferCount)
     : BufferSize(getAvailableBufferSize() / BufferCount),
-      BatchSize(BufferSize / sizeof(ParameterType)), Parameters(BatchSize) {
+      BatchSize(ParameterStorageBytes / sizeof(ParameterType)),
+      Parameters(BatchSize) {
   if (BufferSize <= 0 || BatchSize < 100)
     report_fatal_error("Not enough L1 cache");
+  const size_t ParameterBytes = Parameters.size() * sizeof(ParameterType);
+  const size_t BufferBytes = BufferSize * BufferCount;
+  if (ParameterBytes + BufferBytes + L1LeftAsideBytes > getL1DataCacheSize())
+    report_fatal_error(
+        "We're splitting a buffer of the size of the L1 cache between a data "
+        "buffer and a benchmark parameters buffer, so by construction the "
+        "total should not exceed the size of the L1 cache");
 }
 
 size_t ParameterBatch::getBatchBytes() const {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138111.475782.patch
Type: text/x-patch
Size: 1604 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20221116/551a53b9/attachment.bin>