[libc-commits] [PATCH] D122363: [libc][obvious] only test FILE on working platforms

Thu Mar 24 04:24:59 PDT 2022

lntue accepted this revision.
lntue added a comment.

In D122363#3404232 <https://reviews.llvm.org/D122363#3404232>, @sivachandra wrote:

> I thought a test was already skipped if it had missing deps. But, it looks like we skip a test only if it has skipped entrypoints: https://github.com/llvm/llvm-project/blob/main/libc/cmake/modules/LLVMLibCTestRules.cmake#L32.
>
> While this change LGTM for now, I think a more robust way to skip tests would be by skipping if there are any missing deps. It can be done as a separate cleanup.

+1 on skipping on any missing dep in a separate cleanup.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122363/new/

https://reviews.llvm.org/D122363