[libc-commits] [PATCH] D122363: [libc][obvious] only test FILE on working platforms

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added a comment.
This revision is now accepted and ready to land.

I thought a test was already skipped if it had missing deps. But, it looks like we skip a test only if it has skipped entrypoints: https://github.com/llvm/llvm-project/blob/main/libc/cmake/modules/LLVMLibCTestRules.cmake#L32.

While this change LGTM for now, I think a more robust way to skip tests would be by skipping if there are any missing deps. It can be done as a separate cleanup.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122363/new/

https://reviews.llvm.org/D122363