[libc-commits] [PATCH] D121564: [libc] Let exhaustive tests indicate each interval PASSED/FAILED.

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/test/src/math/exhaustive/exp2f_test.cpp:31
     } while (bits++ < stop);
+    return result;
   }
----------------
This pattern seems to have a logic flaw. For example, since we use an `EXPECT_<>` macro, a following success/failure can overwrite the previous failure/success. You probably want `result &&= <...>` on line 28?


================
Comment at: libc/utils/UnitTest/LibcTest.h:404
       return;                                                                  \
   } while (0)
 
----------------
To math the pattern of other `ASSERT_<>` macros, can we construct `ASSERT_THAT` using `EXPECT_THAT`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121564/new/

https://reviews.llvm.org/D121564