[libc-commits] [PATCH] D121564: [libc] Let exhaustive tests indicate each interval PASSED/FAILED.
Tue Ly via Phabricator via libc-commits
libc-commits at lists.llvm.org
Mon Mar 14 08:10:04 PDT 2022
lntue added inline comments.
Comment at: libc/test/src/math/exhaustive/exhaustive_test.h:26
+ virtual void check(T start, T stop, mpfr::RoundingMode rounding,
+ bool &result) = 0;
> Since its a bool value, would it better as a return value instead of reference argument?
Updated to return to bool value.
Comment at: libc/test/src/math/exhaustive/expf_test.cpp:31
} while (bits++ < stop);
+ result = true;
> If you use `EXPECT_<...>` macro as opposed to `ASSERT_<...>` macro, wouldn't `result` always get set to `true`?
Fixed EXPECT_<...> macros to return bool values.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libc-commits