[libc-commits] [PATCH] D127046: [libc][math] fmod/fmodf implementation.

Mon Jun 6 04:46:07 PDT 2022

orex added a comment.

In D127046#3559587 <https://reviews.llvm.org/D127046#3559587>, @sivachandra wrote:

> Thanks a lot for the patch. It seems like it includes a bunch of cleanups / "better this way" items not related to the main goal of the patch. Can you please separate out those parts in to a different patch so that we can keep the review focused? Also, we cannot strictly use std C++ headers. So, no `cerrno` also. Include `errno.h` instead.

Thank you for the comment. I've picked out 3 "better this way" commits:
https://reviews.llvm.org/D127088
https://reviews.llvm.org/D127091
https://reviews.llvm.org/D127097

I'll rebase this commit, when the changes above will be submitted.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127046/new/

https://reviews.llvm.org/D127046