[libc-commits] [PATCH] D127046: [libc][math] fmod/fmodf implementation.

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Sun Jun 5 23:42:10 PDT 2022


sivachandra added a comment.

Thanks a lot for the patch. It seems like it includes a bunch of cleanups / "better this way" items not related to the main goal of the patch. Can you please separate out those parts in to a different patch so that we can keep the review focused? Also, we cannot strictly use std C++ headers. So, no `cerrno` also. Include `errno.h` instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127046/new/

https://reviews.llvm.org/D127046



More information about the libc-commits mailing list