[libc-commits] [PATCH] D128916: [reland] algorithm_test.cpp

[Guillaume Chatelet via Phabricator via libc-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG1514acb20f40: [reland] algorithm_test.cpp (authored by gchatelet).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128916/new/

https://reviews.llvm.org/D128916

Files:
  libc/test/src/string/memory_utils/CMakeLists.txt


Index: libc/test/src/string/memory_utils/CMakeLists.txt
===================================================================
--- libc/test/src/string/memory_utils/CMakeLists.txt
+++ libc/test/src/string/memory_utils/CMakeLists.txt
@@ -1,18 +1,19 @@
+# These tests are only exercising implementation details
+#  - They don't need to be compiled with '-ffreestanding'
+#  - They can use C++ facilities like <iostream>.
 add_libc_unittest(
-  utils_test
+  implementation_details_test
   SUITE
     libc_string_unittests
   SRCS
     address_test.cpp
-    # algorithm_test.cpp
+    algorithm_test.cpp
     backend_test.cpp
     elements_test.cpp
     memory_access_test.cpp
     utils_test.cpp
   COMPILE_OPTIONS
     ${LIBC_COMPILE_OPTIONS_NATIVE}
-    -ffreestanding
-    -pthread
   DEPENDS
     libc.src.string.memory_utils.memory_utils
     libc.src.__support.CPP.array


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D128916.441654.patch
Type: text/x-patch
Size: 871 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20220701/3b71d8a2/attachment.bin>