[libc-commits] [libc] 1514acb - [reland] algorithm_test.cpp

Guillaume Chatelet via libc-commits libc-commits at lists.llvm.org
Fri Jul 1 03:45:56 PDT 2022


Author: Guillaume Chatelet
Date: 2022-07-01T10:45:29Z
New Revision: 1514acb20f404fa3fe0e20f068b1caf763396176

URL: https://github.com/llvm/llvm-project/commit/1514acb20f404fa3fe0e20f068b1caf763396176
DIFF: https://github.com/llvm/llvm-project/commit/1514acb20f404fa3fe0e20f068b1caf763396176.diff

LOG: [reland] algorithm_test.cpp

Removing `-ffreestanding` for the tests should allow us to use `<iostream>`

Differential Revision: https://reviews.llvm.org/D128916

Added: 
    

Modified: 
    libc/test/src/string/memory_utils/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/libc/test/src/string/memory_utils/CMakeLists.txt b/libc/test/src/string/memory_utils/CMakeLists.txt
index df481ee15a6df..d2178da30f9b7 100644
--- a/libc/test/src/string/memory_utils/CMakeLists.txt
+++ b/libc/test/src/string/memory_utils/CMakeLists.txt
@@ -1,18 +1,19 @@
+# These tests are only exercising implementation details
+#  - They don't need to be compiled with '-ffreestanding'
+#  - They can use C++ facilities like <iostream>.
 add_libc_unittest(
-  utils_test
+  implementation_details_test
   SUITE
     libc_string_unittests
   SRCS
     address_test.cpp
-    # algorithm_test.cpp
+    algorithm_test.cpp
     backend_test.cpp
     elements_test.cpp
     memory_access_test.cpp
     utils_test.cpp
   COMPILE_OPTIONS
     ${LIBC_COMPILE_OPTIONS_NATIVE}
-    -ffreestanding
-    -pthread
   DEPENDS
     libc.src.string.memory_utils.memory_utils
     libc.src.__support.CPP.array


        


More information about the libc-commits mailing list