[libc-commits] [PATCH] D136487: [libc.search] [PATCH 1/6] add wyhash as a header library

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Dec 15 11:00:20 PST 2022


michaelrj added a comment.

The patch overall looks good to me, but I'd like to see some more comprehensive tests. Specifically it would be good to demonstrate the avalanche effect by having test inputs that differ by one bit but have outputs that differ by much more. Once that is done I will approve.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136487/new/

https://reviews.llvm.org/D136487



More information about the libc-commits mailing list