[libc-commits] [PATCH] D136487: [libc.search] [PATCH 1/6] add wyhash as a header library

Schrodinger ZHU Yifan via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Dec 8 09:04:50 PST 2022


SchrodingerZhu updated this revision to Diff 481317.
SchrodingerZhu added a comment.

This commit updates the wyhash header library. 
Notice that subsequent changes in other stacked patches are yet to be uploaded.

Changes:

- address code review
  - Use looped read with shift to avoid memcpy and endian conversion
  - Address the source of secret parameters
  - Move wyhash to `internal namespace` (TODO: Similar change need to be applied to other patches)
- Sync wyhash Implementation with version 4.1
  - hash function behavor changes at the initializing and finalizing stage
  - generate new sanity test hash values with ea3b25e1aef55d90f707c3a292eeb9162e2615d8 ```c++ for (size_t i = 0; i < 7; ++i) { std::cout << std::hex << "0x" << wyhash(data[i], strlen(data[i]), i, _wyp) << std::endl; } ```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136487/new/

https://reviews.llvm.org/D136487

Files:
  libc/src/__support/CMakeLists.txt
  libc/src/__support/wyhash.h
  libc/test/src/__support/CMakeLists.txt
  libc/test/src/__support/wyhash_test.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136487.481317.patch
Type: text/x-patch
Size: 6543 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20221208/34345ff3/attachment.bin>


More information about the libc-commits mailing list