[libc-commits] [PATCH] D132638: [NFC][libc] Move Uint implementation to parent directory

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Sun Aug 28 21:57:13 PDT 2022


sivachandra added inline comments.


================
Comment at: libc/test/src/CMakeLists.txt:34
 add_subdirectory(inttypes)
-add_subdirectory(math)
+# add_subdirectory(math)
 add_subdirectory(string)
----------------
orex wrote:
> Hello. Sorry for disturbing in closed review, but commenting this line completely disable all math tests in LLVM for me. Can you provide any additional verification that this is really necessary and math tests should be enabled somehow in a different way?
I think it just a miss so I have landed this: https://github.com/llvm/llvm-project/commit/3a5ec60ae3d8d7da70440ade8e767d25532538f4


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132638/new/

https://reviews.llvm.org/D132638



More information about the libc-commits mailing list