[libc-commits] [PATCH] D132638: [NFC][libc] Move Uint implementation to parent directory

Kirill Okhotnikov via Phabricator via libc-commits libc-commits at lists.llvm.org
Sun Aug 28 07:01:42 PDT 2022


orex added inline comments.


================
Comment at: libc/test/src/CMakeLists.txt:34
 add_subdirectory(inttypes)
-add_subdirectory(math)
+# add_subdirectory(math)
 add_subdirectory(string)
----------------
Hello. Sorry for disturbing in closed review, but commenting this line completely disable all math tests in LLVM for me. Can you provide any additional verification that this is really necessary and math tests should be enabled somehow in a different way?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132638/new/

https://reviews.llvm.org/D132638



More information about the libc-commits mailing list