[libc-commits] [PATCH] D132121: [NFC][libc] rearrange aarch64 memset code to better match new implementation

[Clement Courbet via Phabricator via libc-commits]

courbet accepted this revision.
courbet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/src/string/memory_utils/memset_implementations.h:95
     return splat_set<HeadTail<_16>>(dst, value, count);
   if (count <= 96) {
     splat_set<_32>(dst, value);
----------------
This is magical. Maybe at least spell it `64 + 32` ?


================
Comment at: libc/src/string/memory_utils/memset_implementations.h:103
   }
-  if (count < 448 || value != 0 || !AArch64ZVA(dst, count))
+  if (count >= 448 && value == 0 && hasZva())
+    return splat_set<Align<_64, Arg::_1>::Then<Loop<Zva64>>>(dst, 0, count);
----------------
ditto.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132121/new/

https://reviews.llvm.org/D132121