[libc-commits] [PATCH] D131300: [libc] Support StringView equality tests

[Siva Chandra via Phabricator via libc-commits]

sivachandra added a comment.

In D131300#3710101 <https://reviews.llvm.org/D131300#3710101>, @abrachet wrote:

> In D131300#3708985 <https://reviews.llvm.org/D131300#3708985>, @sivachandra wrote:
>
>> LGTM but will this cause problems to FuchsiaTest: https://github.com/llvm/llvm-project/blob/main/libc/utils/UnitTest/FuchsiaTest.h
>
> This will be fine there as long as `__llvm_libc::cpp::StringView` has an `operator==`. Though as a drive by comment here, I think the better way to compare `StringView`'s would be to make sure they have an `operator const char *()` and just use `EXPECT_STREQ`

I don't think StringView data is necessarily null-terminated?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131300/new/

https://reviews.llvm.org/D131300