[libc-commits] [PATCH] D131300: [libc] Support StringView equality tests
Alex Brachet via Phabricator via libc-commits
libc-commits at lists.llvm.org
Tue Aug 9 09:00:10 PDT 2022
abrachet added a comment.
In D131300#3708985 <https://reviews.llvm.org/D131300#3708985>, @sivachandra wrote:
> LGTM but will this cause problems to FuchsiaTest: https://github.com/llvm/llvm-project/blob/main/libc/utils/UnitTest/FuchsiaTest.h
This will be fine there as long as `__llvm_libc::cpp::StringView` has an `operator==`. Though as a drive by comment here, I think the better way to compare `StringView`'s would be to make sure they have an `operator const char *()` and just use `EXPECT_STREQ`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131300/new/
https://reviews.llvm.org/D131300
More information about the libc-commits
mailing list