[libc-commits] [PATCH] D114302: [libc] apply new lint rules

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Nov 29 15:31:32 PST 2021


michaelrj added inline comments.


================
Comment at: libc/src/__support/detailed_powers_of_ten.h:34
 
-static const uint64_t DETAILED_POWERS_OF_TEN[696][2] = {
+static const uint64_t detailed_powers_of_ten[696][2] = {
     {0x1732C869CD60E453, 0xFA8FD5A0081C0288}, // 1e-348
----------------
sivachandra wrote:
> lntue wrote:
> > Can this one be all CAPS?
> Yes, for consistency. 
I changed it to `constexpr` so that the lint rules would make it caps


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114302/new/

https://reviews.llvm.org/D114302



More information about the libc-commits mailing list