[libc-commits] [PATCH] D114302: [libc] apply new lint rules

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Nov 29 08:50:12 PST 2021

sivachandra added a comment.

In general looks good. Please ping after updating the commit message and fixing the broken tests.

Comment at: libc/src/__support/CPP/TypeTraits.h:34
 template <typename T1, typename T2>
-static constexpr bool IsSameV = IsSame<T1, T2>::Value;
+static constexpr bool IS_SAME_V = IsSame<T1, T2>::VALUE;
lntue wrote:
> If we are going to change these, I feel like changing to match std::is_same_v style for these templates would be more beneficial.
We should have a consistent style. So, I am inclined towards `IS_SAME_V` and fix the other constants/constexpr values to follow this style.

Comment at: libc/src/__support/detailed_powers_of_ten.h:34
-static const uint64_t DETAILED_POWERS_OF_TEN[696][2] = {
+static const uint64_t detailed_powers_of_ten[696][2] = {
     {0x1732C869CD60E453, 0xFA8FD5A0081C0288}, // 1e-348
lntue wrote:
> Can this one be all CAPS?
Yes, for consistency. 

  rG LLVM Github Monorepo



More information about the libc-commits mailing list