[libc-commits] [PATCH] D106706: [libc] Clean up Windows macros

Arthur Eubanks via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Jul 23 13:49:04 PDT 2021


aeubanks added a comment.

not just ARM but also x86/x64 (which is what we're working with)

maybe a reference to https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros in the description would be good



================
Comment at: libc/utils/UnitTest/PlatformDefs.h:12
 
-#if !(defined(_WIN32) || defined(_WIN64))
+#if !(defined(_WIN32))
 #define ENABLE_SUBPROCESS_TESTS
----------------
extra parentheses


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106706/new/

https://reviews.llvm.org/D106706



More information about the libc-commits mailing list