[libc-commits] [PATCH] D106706: [libc] Clean up Windows macros

Caitlyn Cano via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Jul 23 13:43:08 PDT 2021


caitlyncano created this revision.
caitlyncano added a reviewer: aeubanks.
Herald added subscribers: libc-commits, ecnelises, tschuett, kristof.beyls.
Herald added a project: libc-project.
caitlyncano requested review of this revision.

This clean-up removes checks for _WIN64, as the _WIN32 macro returns 1
whenever the compilation targe is 32- or 64-bit ARM.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D106706

Files:
  libc/utils/FPUtil/PlatformDefs.h
  libc/utils/FPUtil/TestHelpers.cpp
  libc/utils/UnitTest/PlatformDefs.h


Index: libc/utils/UnitTest/PlatformDefs.h
===================================================================
--- libc/utils/UnitTest/PlatformDefs.h
+++ libc/utils/UnitTest/PlatformDefs.h
@@ -9,7 +9,7 @@
 #ifndef LLVM_LIBC_UTILS_UNITTEST_PLATFORMDEFS_H
 #define LLVM_LIBC_UTILS_UNITTEST_PLATFORMDEFS_H
 
-#if !(defined(_WIN32) || defined(_WIN64))
+#if !(defined(_WIN32))
 #define ENABLE_SUBPROCESS_TESTS
 #endif
 
Index: libc/utils/FPUtil/TestHelpers.cpp
===================================================================
--- libc/utils/FPUtil/TestHelpers.cpp
+++ libc/utils/FPUtil/TestHelpers.cpp
@@ -74,7 +74,7 @@
 template void describeValue<long double>(const char *, long double,
                                          testutils::StreamWrapper &);
 
-#if defined(_WIN32) || defined(_WIN64)
+#if defined(_WIN32)
 #define sigjmp_buf jmp_buf
 #define sigsetjmp(buf, save) setjmp(buf)
 #define siglongjmp(buf, val) longjmp(buf, val)
Index: libc/utils/FPUtil/PlatformDefs.h
===================================================================
--- libc/utils/FPUtil/PlatformDefs.h
+++ libc/utils/FPUtil/PlatformDefs.h
@@ -13,7 +13,7 @@
 #define X87_FPU
 #endif
 
-#if defined(_WIN32) || defined(_WIN64)
+#if defined(_WIN32)
 #define LONG_DOUBLE_IS_DOUBLE
 #endif
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106706.361331.patch
Type: text/x-patch
Size: 1267 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20210723/df6b04d3/attachment.bin>


More information about the libc-commits mailing list